-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CMakePresets.json file. #1089
base: master
Are you sure you want to change the base?
Conversation
Allows easy build with Visual Studio - CMake integration. Debug and Release configurations added. installRoot set to `build/install/`
Curious why only x64 builds when the preferred for windows builds is 32? |
Partly personal habit of just building x64 and partly because I didn't realise 32 was the preferred. I'll add x86 and some RelWithDebInfo configurations too. |
Just because there are no mods for 64-bit out there, and many people still play old mods like JA+, 64-bit is unavailable for them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence about approving this since we've so far managed to not have any text editor or IDE specific files in the repo :/
Provides equivalent functionality. Can be used directly with CMake and is not MSVC specific.
… into build_improvements
Removed whitespace from names and reduced verbosity. Added CMakeUserPresets.json to .gitignore Added simple CMakeUserPresets.json template for devs to copy.
That's understandable. I was going to close the PR but I saw that CMake added a new feature called Presets, which is basically the sort of JSON file except that it can be parsed by CMake directly and isn't IDE specific. https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#build-preset I added some x86 configurations and it seems to work well with VS code. VS only supports it under preview at the moment so I haven't test that. I'm not sure about other IDEs.
|
Allows easy build with Visual Studio - CMake integration.
Debug and Release configurations added.
installRoot set to
build/install/